Fix exit code error in build command on Node 20+ #599
Conversation
🦋 Changeset detectedLatest commit: 741d455 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
jrolfs
force-pushed
the
fix/node-20-exit-code
branch
from
690270b to
741d455
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
not stale |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
not stale |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
not stale 🙏 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
not... stale... 🙏🏻 |
|
This is the funniest and most tragic pull request comment thread I've seen in years. @jrolfs thanks for doing this dude. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
not stale. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
not stale. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
not stale |
|
@jrolfs I merged your fix in timlrx/contentlayer2#8 - published as contentlayer2 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
🇫 |
|
@timlrx thanks and thanks for getting a fork off the ground! I was considering doing it myself but will switch our stuff over to yours (currently running a patched version). |
|
For anyone following this, I switched to the fork, and it's working great and includes this fix. I wrote some docs on how to switch over here. |
|
Thank you very much guys. 🙏 |
This should close #495 pending @schickling's take on whether this is the correct remediation.
Although I'm very keen to dig more into Effect, I'm still very much a noob in that department. This fix assumes that since everything in the command is wrapped in an
Effectthat no additional error handling is necessary to handle actual runtime errors, but I haven't tested out that assumption yet.